I think it's between Haffner and McAllister.

I'm going with the sheriff, at least there is some mystery about him which makes him much more intriguing than Haffner who doesn't seem to have much of a personality..

Which one would you rather see as Red John?    GREEN  -  Haffner
                                                                        RED      -  Sheriff